fix(dli): catch and handle the 408 errors #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
deer-hang
reviewed
May 16, 2024
| return diag.Errorf("error creating DLI database (%s): %s", dbName, err) | ||
| } | ||
| } else if resp != nil && !resp.IsSuccess { | ||
| return diag.Errorf("the request was sent successfully, but some errors occurred: %s", resp.Message) |
There was a problem hiding this comment.
if resp == nil {
return diag.Errorf("error creating DLI database (%s): The creation API response is empty.", dbName)
}
if !resp.IsSuccess {
return diag.Errorf("the request was sent successfully, but some errors occurred: %s", resp.Message)
}
There was a problem hiding this comment.
we don't care about the case of the response is nil, because we don't need to parse it.
deer-hang
reviewed
May 16, 2024
| if err != nil { | ||
| return diag.Errorf("error create DLI datatable (%s) to the database (%s): %s", databaseName, tableName, err) | ||
| } | ||
| } else if resp != nil && !resp.IsSuccess { |
deer-hang
reviewed
May 16, 2024
| if _, ok := queryErr.(golangsdk.ErrDefault404); !ok { | ||
| return detail, "ERROR", queryErr | ||
| } | ||
| return detail, "COMPLETED", nil |
There was a problem hiding this comment.
Variable detail may be nil.
There was a problem hiding this comment.
the result of Get() method during golangsdk will have the type value (corresponding structure) in any times, will not be nil (nil means the type and value are both empty)
|
Please add descriptions of |
Lance52259
force-pushed
the
br_dli_408_catch
branch
from
06e5b1c
to
a8190a9
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When resource (database or data table) create or delete by provider, due to the shared queue is their bottom layer relies resource, timeout errors (status code: 408, error code: DLI.0019) will be frequently returned when the usage is large.
If you try again immediately, the following error will be thrown：
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed