-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: feat(apig): new parameters supported for custom authorizer resource #4740
Merged
github-ci-robot
merged 2 commits into
huaweicloud:master
from
Lance52259:br_apig_custom_authorization_fix
May 16, 2024
Merged
fix: feat(apig): new parameters supported for custom authorizer resource #4740
github-ci-robot
merged 2 commits into
huaweicloud:master
from
Lance52259:br_apig_custom_authorization_fix
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 6, 2024
[APPROVALNOTIFIER] This PR is APPROVED This PR has been approved by: @Lance52259 |
Lance52259
force-pushed
the
br_apig_custom_authorization_fix
branch
from
May 7, 2024 08:43
05a0cbd
to
6f19835
Compare
|
Lance52259
force-pushed
the
br_apig_custom_authorization_fix
branch
from
May 16, 2024 01:56
6f19835
to
e3c1f58
Compare
deer-hang
reviewed
May 16, 2024
@@ -48,6 +49,12 @@ The following arguments are supported: | |||
|
|||
* `function_urn` - (Required, String) Specifies the uniform function URN of the function graph resource. | |||
|
|||
* `function_version` - (Required, String) Specifies the version of the FGS function. | |||
|
|||
* `network_type` - (Optional, String) Specifies the framework type of the function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify what type
types can be used.
Lance52259
force-pushed
the
br_apig_custom_authorization_fix
branch
from
May 16, 2024 08:14
e3c1f58
to
819b1c1
Compare
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The parameter
authorizer_uri
is no longer support the function version, and they are provideauthorizer_version
to support it.It is a breaking changes for API users, and it cause the creation of the provider resource failed.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed