Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feat(apig): new parameters supported for custom authorizer resource #4740

Merged

Conversation

Lance52259
Copy link
Collaborator

What this PR does / why we need it:
The parameter authorizer_uri is no longer support the function version, and they are provide authorizer_version to support it.
It is a breaking changes for API users, and it cause the creation of the provider resource failed.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. new version parameter supported and fix the compare error.
2. new parameters are supported for custom authorizer.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

PENDING

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259
Copy link
Collaborator Author

make testacc TEST='./huaweicloud/services/acceptance/apig' TESTARGS='-run=TestAccApi_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run=TestAccApi_basic -timeout 360m -parallel 4
=== RUN   TestAccApi_basic
=== PAUSE TestAccApi_basic
=== CONT  TestAccApi_basic
--- PASS: TestAccApi_basic (655.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      655.188s

@@ -48,6 +49,12 @@ The following arguments are supported:

* `function_urn` - (Required, String) Specifies the uniform function URN of the function graph resource.

* `function_version` - (Required, String) Specifies the version of the FGS function.

* `network_type` - (Optional, String) Specifies the framework type of the function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify what type types can be used.

@Lance52259 Lance52259 force-pushed the br_apig_custom_authorization_fix branch from e3c1f58 to 819b1c1 Compare May 16, 2024 08:14
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 16, 2024
@github-ci-robot github-ci-robot merged commit 5d8c4d5 into huaweicloud:master May 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants