Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apig/sign): new data source supported for associated res query #4808

Merged
merged 1 commit into from
May 27, 2024
Merged

feat(apig/sign): new data source supported for associated res query #4808

merged 1 commit into from
May 27, 2024
+695 −0

Conversation

Lance52259
Copy link
Collaborator

What this PR does / why we need it:
Support a new data source to query associated signatures.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. support a new data source to query associated signatures.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/apig' TESTARGS='-run=TestAccDataSourceApiAssociatedSignatures_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run=TestAccDataSourceApiAssociatedSignatures_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceApiAssociatedSignatures_basic
=== PAUSE TestAccDataSourceApiAssociatedSignatures_basic
=== CONT  TestAccDataSourceApiAssociatedSignatures_basic
--- PASS: TestAccDataSourceApiAssociatedSignatures_basic (658.60s)              
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      658.646s

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_apig_api_associated_signs branch from e0c68c3 to b9af18c Compare May 13, 2024 12:48
@Lance52259
Copy link
Collaborator Author 

make testacc TEST='./huaweicloud/services/acceptance/apig' TESTARGS='-run=TestAccDataSourceApiAssociatedSignatures_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run=TestAccDataSourceApiAssociatedSignatures_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceApiAssociatedSignatures_basic
=== PAUSE TestAccDataSourceApiAssociatedSignatures_basic
=== CONT  TestAccDataSourceApiAssociatedSignatures_basic
--- PASS: TestAccDataSourceApiAssociatedSignatures_basic (632.88s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      632.928s

@Lance52259 Lance52259 force-pushed the br_apig_api_associated_signs branch from b9af18c to 3902d0c Compare May 16, 2024 01:50
deer-hang
deer-hang reviewed May 16, 2024
View reviewed changes
...loud/services/acceptance/apig/data_source_huaweicloud_apig_api_associated_signatures_test.go Outdated
name = "%[2]s"
port = 8000
balance_strategy = 2
member_type = "ecs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format alignment.

@Lance52259 Lance52259 force-pushed the br_apig_api_associated_signs branch from 3902d0c to d36ef39 Compare May 16, 2024 08:00
@deer-hang
Copy link
Contributor

/lgtm

@Lance52259 Lance52259 force-pushed the br_apig_api_associated_signs branch from d36ef39 to e372ce3 Compare May 27, 2024 03:29
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 27, 2024
@github-ci-robot github-ci-robot merged commit b51bb93 into huaweicloud:master May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deer-hang deer-hang deer-hang left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Lance52259 @github-ci-robot @deer-hang