Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dds): support setting balancer configuration in instance #4815

Merged
merged 1 commit into from
May 16, 2024
Merged

feat(dds): support setting balancer configuration in instance #4815

merged 1 commit into from
May 16, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented May 14, 2024 •
edited

What this PR does / why we need it:
Support balancer configuration in instance.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST="./huaweicloud/services/acceptance/dds" TESTARGS="-run  TestAccDDSV3Instance_withConfigurationSharding"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dds -v -run  TestAccDDSV3Instance_withConfigurationSharding -timeout 360m -parallel 4
=== RUN   TestAccDDSV3Instance_withConfigurationSharding
=== PAUSE TestAccDDSV3Instance_withConfigurationSharding
=== CONT  TestAccDDSV3Instance_withConfigurationSharding
--- PASS: TestAccDDSV3Instance_withConfigurationSharding (1759.03s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dds       1759.093s

@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_setting_balancer_configuration_in_instance branch 2 times, most recently from cfc0a53 to b2569b9 Compare May 14, 2024 10:00
@saf3dfsa saf3dfsa changed the title feat(dds): support balancer configuration in instance feat(dds): support setting balancer configuration in instance May 14, 2024
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 15, 2024
@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_setting_balancer_configuration_in_instance branch from b2569b9 to 050faae Compare May 15, 2024 08:35
@github-ci-robot github-ci-robot removed the LGTM /lgtm label May 15, 2024
@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_setting_balancer_configuration_in_instance branch from 050faae to 853f665 Compare May 16, 2024 06:18
@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2024
github-ci-robot
github-ci-robot approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit 8ba0957 into huaweicloud:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot