feat(apig): add new datasource to get list of signatures #4818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangyuancheng01
force-pushed
the
apig_sign
branch
from
4e5b246
to
f49ead3
Compare
wangyuancheng01
force-pushed
the
apig_sign
branch
5 times, most recently
from
7d2b9d4
to
c8bb049
Compare
docs/data-sources/apig_signatures.md
Outdated
| variable "instance_id" {} | ||
| variable "signature_name" {} | ||
|
|
||
| data "huaweicloud_apig_api_associated_acl_policies" "test" { |
There was a problem hiding this comment.
Suggested change
| data "huaweicloud_apig_api_associated_acl_policies" "test" { | |
| data "huaweicloud_apig_signatures" "test" { |
| signSecret := utils.Reverse(signKey) | ||
|
|
||
| return fmt.Sprintf(` | ||
| %s |
There was a problem hiding this comment.
Suggested change
| %s | |
| %s | |
wangyuancheng01
force-pushed
the
apig_sign
branch
3 times, most recently
from
fcbb17f
to
5f2c93e
Compare
Lance52259
reviewed
May 21, 2024
docs/data-sources/apig_signatures.md
Outdated
|
|
||
| * `bind_num` - The number of bound APIs. | ||
|
|
||
| * `created_at` - The creation time of the signature. |
There was a problem hiding this comment.
Suggested change
| * `created_at` - The creation time of the signature. | |
| * `created_at` - The creation time of the signature, in RFC3339 format. |
wangyuancheng01
force-pushed
the
apig_sign
branch
from
5f2c93e
to
759be3e
Compare
|
/approve |
github-ci-robot
added
LGTM
github-ci-robot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add new datasource to get list of signatures.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed