Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fgs): add datasource to get dependency package versions #4819

Merged
merged 2 commits into from
May 17, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

  1. Add attribute parameter dependency_id for dependency package version resource.
  2. Add attribute parameter versions for dependency package datasource.
  3. Add new dataSource to get the list of theversions under specified dependency package.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST=./huaweicloud/services/acceptance/fgs TESTARGS='-run TestAccDependencyVersion_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccDependencyVersion_basic -timeout 360m -parallel 4

=== RUN   TestAccDependencyVersion_basic
=== PAUSE TestAccDependencyVersion_basic
=== CONT  TestAccDependencyVersion_basic
--- PASS: TestAccDependencyVersion_basic (49.51s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       51.023s

make testacc TEST=./huaweicloud/services/acceptance/fgs TESTARGS='-run TestAccFunctionGraphDependencies_filterByName'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccFunctionGraphDependencies_filterByName -timeout 360m -parallel 4
=== RUN   TestAccFunctionGraphDependencies_filterByName
=== PAUSE TestAccFunctionGraphDependencies_filterByName
=== CONT  TestAccFunctionGraphDependencies_filterByName
--- PASS: TestAccFunctionGraphDependencies_filterByName (20.55s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       20.591s

make testacc TEST=./huaweicloud/services/acceptance/fgs TESTARGS='-run TestAccDependencyVersions_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/fgs -v -run TestAccDependencyVersions_basic -timeout 360m -parallel 4
=== RUN   TestAccDependencyVersions_basic
=== PAUSE TestAccDependencyVersions_basic
=== CONT  TestAccDependencyVersions_basic
--- PASS: TestAccDependencyVersions_basic (50.89s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/fgs       50.937s

@wuzhuanhong wuzhuanhong changed the title add datasource to get dependency package versions feat(fgs): "add datasource to get dependency package versions" May 15, 2024
@wuzhuanhong wuzhuanhong changed the title feat(fgs): "add datasource to get dependency package versions" feat(fgs): add datasource to get dependency package versions May 15, 2024
@wuzhuanhong wuzhuanhong force-pushed the fgs_dep branch 3 times, most recently from 8c4a032 to e61175e Compare May 15, 2024 09:37
@Lance52259
Copy link
Collaborator

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 843dcd7 into huaweicloud:master May 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants