Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RDS): add rds pg plugin parameter value range data source #4820

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add rds pg plugin parameter value range data source
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add rds pg plugin parameter value range data source

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST=./huaweicloud/services/acceptance/rds/ TESTARGS='-run TestAccDatasourcePgPluginParameterValueRange_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/rds/ -v -run TestAccDatasourcePgPluginParameterValueRange_basic -timeout 360m -parallel 4
=== RUN   TestAccDatasourcePgPluginParameterValueRange_basic
=== PAUSE TestAccDatasourcePgPluginParameterValueRange_basic
=== CONT  TestAccDatasourcePgPluginParameterValueRange_basic
--- PASS: TestAccDatasourcePgPluginParameterValueRange_basic (794.73s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/rds       794.769s

@houpeng80 houpeng80 force-pushed the rds_pg_plugin_parameter_value_range branch from 1fc619b to 5597f12 Compare May 16, 2024 08:31
@Jason-Zhang9309
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 17, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit f8cbfcb into huaweicloud:master May 17, 2024
14 checks passed
@houpeng80 houpeng80 deleted the rds_pg_plugin_parameter_value_range branch May 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants