feat(dds): support to modify params for instance #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
houpeng80
reviewed
May 16, 2024
| return diag.FromErr(err) | ||
| } | ||
|
|
||
| d.SetId(instId) |
There was a problem hiding this comment.
the ID is error, if group or node params are modified, then the instance ID may same, but entity ID is different, so the resource ID should contains entity ID if the valuie of entity_id is not empty
| } | ||
| } | ||
|
|
||
| func resourceDDSInstanceParametersModifyRead(ctx context.Context, _ *schema.ResourceData, _ interface{}) diag.Diagnostics { |
There was a problem hiding this comment.
read method shoud be added, API:
https://support.huaweicloud.com/api-dds/dds_api_0108.html
huaweicloud/services/dds/resource_huaweicloud_dds_instance_parameters_modify.go
Show resolved
Hide resolved
saf3dfsa
force-pushed
the
feat(dds)_support_to_modify_params_for_instance
branch
from
5a92786
to
75bb2e8
Compare
saf3dfsa
force-pushed
the
feat(dds)_support_to_modify_params_for_instance
branch
from
75bb2e8
to
7380565
Compare
|
/lgtm |
github-ci-robot
added
LGTM
github-ci-robot
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support to modify params for instance.
PR Checklist
Acceptance Steps Performed