Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): add datasource CSS logstash certificates #4827

Merged

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented May 15, 2024

What this PR does / why we need it:
add datasource CSS logstash certificates

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add datasource CSS logstash certificates

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/css' TESTARGS='-run TestAccDataSourceCssLogstashCertificates'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/css -v -run TestAccDataSourceCssLogstashCertificates -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCssLogstashCertificates_basic
=== PAUSE TestAccDataSourceCssLogstashCertificates_basic
=== CONT  TestAccDataSourceCssLogstashCertificates_basic
--- PASS: TestAccDataSourceCssLogstashCertificates_basic (872.75s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/css       872.840s

@luoping-12345 luoping-12345 force-pushed the css_logstash_certificates branch 2 times, most recently from ca23d79 to 3515695 Compare May 16, 2024 03:23
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 17, 2024
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 2912934 into huaweicloud:master May 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants