Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CFW): modify the type of the filter field that valid values contain zero value #4828

Merged

Conversation

profoundwu
Copy link
Contributor

What this PR does / why we need it:
modify the type of the filter field that valid values contain zero value
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. modify the type of address_type from int to string
2. modify the type of ref_count from int to string

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccDataSourceCfwDomainNameGroups_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccDataSourceCfwDomainNameGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCfwDomainNameGroups_basic
=== PAUSE TestAccDataSourceCfwDomainNameGroups_basic
=== CONT  TestAccDataSourceCfwDomainNameGroups_basic
--- PASS: TestAccDataSourceCfwDomainNameGroups_basic (639.82s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       639.867s

make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccDataSourceCfwAddressGroups_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccDataSourceCfwAddressGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCfwAddressGroups_basic
=== PAUSE TestAccDataSourceCfwAddressGroups_basic
=== CONT  TestAccDataSourceCfwAddressGroups_basic
--- PASS: TestAccDataSourceCfwAddressGroups_basic (64.50s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       64.552s

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label May 16, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 5a4c97d into huaweicloud:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm refactor size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants