-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to add checks with app ids #1844
base: main
Are you sure you want to change the base?
feat: add ability to add checks with app ids #1844
Conversation
40b3783
to
78778a2
Compare
78778a2
to
c8c7b30
Compare
e4a7af4
to
33e1ccb
Compare
/** | ||
* no-arg constructor for the serializer | ||
*/ | ||
public Check() { | ||
} | ||
|
||
/** | ||
* Regular constructor for use in user business logic | ||
* | ||
* @param context | ||
* the context string of the check | ||
* @param appId | ||
* the application ID the check is supposed to come from | ||
*/ | ||
public Check(String context, Integer appId) { | ||
this.context = context; | ||
this.app_id = appId; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | |
* no-arg constructor for the serializer | |
*/ | |
public Check() { | |
} | |
/** | |
* Regular constructor for use in user business logic | |
* | |
* @param context | |
* the context string of the check | |
* @param appId | |
* the application ID the check is supposed to come from | |
*/ | |
public Check(String context, Integer appId) { | |
this.context = context; | |
this.app_id = appId; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this has no constructor, how can the user use the GHBranchProtectionBuilder.addRequiredChecksWithAppIds
method, which accepts this object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jackson is magic. It will do the binding for you.
Description
Fixes #1467
Add ability to receive and specify App IDs for required checks in branch protection rules.
Before submitting a PR:
@link
JavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install site
locally. If this command doesn't succeed, your change will not pass CI.main
. You will create your PR from that branch.When creating a PR: