plugin-flow-builder: fallback , keyword, smart-intent tests #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d bot action tests
…Input to a SmartIntentsApi class to implement a mock
Iru89
changed the title
vanbasten17
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many lines added (292 in one file and 486 in the other) are from the JSON that represents the flow used for testing
Context
We need to create tests to keep adding new features and refactor the plugin without changing the behaviour
Approach taken / Explain the design
For the smart intent test I have created a separate flow so that I don't always have to use the mock (we can discuss if this is the best way or if all tests should go in the same flow)
Testing
This PR only contains changes to add tests and refactors the getSmartIntentNodeByInput function into a class and then creates a mock that modifies only one function of this class.
Add tests for fallback, keyword and smart intent