Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses temperature 0.0 for Phi-3. #1132

Merged
merged 1 commit into from
May 20, 2024
Merged

Uses temperature 0.0 for Phi-3. #1132

merged 1 commit into from
May 20, 2024

Conversation

gugarosa
Copy link
Contributor

Sorry for sending a bunch of PRs on the same matter 馃槃

We decided to set temperature=0.0 to have a more controlled environment and attempt to fix the issue for real. One thing that we were thinking and I don't know the answer is the following:

When the truncation happen, it is done in the left or right side of the context? Is there a way to set it? I looked on the https://github.com/huggingface/chat-ui/blob/main/src/lib/server/models.ts file, but it could be somewhere else.

Thanks and best regards,
Gustavo.

@gary149
Copy link
Collaborator

gary149 commented May 13, 2024

Ok to merge (@nsarrazin is off)

When the truncation happen, it is done in the left or right side of the context? Is there a way to set it?

I think it's left side and no it cannot be set in the config.

@gary149 gary149 self-requested a review May 13, 2024 11:52
@gugarosa
Copy link
Contributor Author

Thanks for reviewing and the inputs on truncation @gary149!

@gary149 gary149 requested review from gary149 and mishig25 May 17, 2024 16:36
@mishig25 mishig25 merged commit e5be264 into huggingface:main May 20, 2024
3 checks passed
mishig25 added a commit that referenced this pull request May 20, 2024
mishig25 added a commit that referenced this pull request May 20, 2024
Revert "Uses temperature 0.0 for Phi-3. (#1132)"

This reverts commit e5be264.
@mishig25
Copy link
Collaborator

mishig25 commented May 20, 2024

@gugarosa I've merged but reverted the changes afterwards #1152

The reason being that, I get this error from our api-inference backend:

Error: Input validation error: temperature must be strictly positive

Would something smaller like temperature: 0.1 that is not 0.0 work ?

@nsarrazin nsarrazin added the huggingchat For issues related to HuggingChat specifically label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
huggingchat For issues related to HuggingChat specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants