Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Collection endpoint #367

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

[WIP]Collection endpoint #367

wants to merge 20 commits into from

Conversation

hackpk
Copy link

@hackpk hackpk commented Nov 27, 2023 •
edited

@hackpk hackpk changed the title Collection endpoint [WIP]Collection endpoint Nov 27, 2023
@vvmnnnkv
Copy link
Collaborator

Hey @hackpk nice work! Do you still have time to finish this off?
I've fixed some boring stuff with unit tests.
I think return types need a bit more ❤️, e.g. using CollectionEntry instead of Api.... Also, unit tests might be grouped in one file to avoid duplication. Otherwise, it looks almost done!

@hackpk
Copy link
Author

hackpk commented Dec 19, 2023

Hi @vvmnnnkv I'm currently busy at work and home. I will only be able to work after 8th Jan if that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coyotte508 coyotte508 coyotte508 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hackpk @vvmnnnkv @coyotte508