Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📰 Update about.md #456

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

📰 Update about.md #456

wants to merge 11 commits into from

Conversation

kadirnar
Copy link

Please let's make about.md files more readable. Thanks ❤️

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/tasks/src/tasks/image-classification/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-classification/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-classification/about.md Outdated Show resolved Hide resolved
@kadirnar
Copy link
Author

kadirnar commented Feb 5, 2024

I did the corrections. I will update other tasks as well. Please don't merge ❤️

@kadirnar
Copy link
Author

kadirnar commented Feb 5, 2024

@merveenoyan Can you check🤩 I updated all tasks related to computer vision.

@@ -15,7 +15,7 @@ With the `transformers` library, you can use the `depth-estimation` pipeline to
```python
from transformers import pipeline

estimator = pipeline(task="depth-estimation", model="Intel/dpt-large")
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large", device=0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I would not include optional arguments such as device to make examples as focused on the task as possible. But let's wait for Merve's opinion :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove the device parameter?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadirnar yes

packages/tasks/src/tasks/image-segmentation/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-classification/about.md Outdated Show resolved Hide resolved
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadirnar thanks a lot for standardizing our docs!!! this is very useful 🤗

@@ -15,7 +15,7 @@ With the `transformers` library, you can use the `depth-estimation` pipeline to
```python
from transformers import pipeline

estimator = pipeline(task="depth-estimation", model="Intel/dpt-large")
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large", device=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kadirnar yes

@SBrandeis SBrandeis removed their request for review March 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants