-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📰 Update about.md #456
base: main
Are you sure you want to change the base?
📰 Update about.md #456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I did the corrections. I will update other tasks as well. Please don't merge ❤️ |
@merveenoyan Can you check🤩 I updated all tasks related to computer vision. |
@@ -15,7 +15,7 @@ With the `transformers` library, you can use the `depth-estimation` pipeline to | |||
```python | |||
from transformers import pipeline | |||
|
|||
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large") | |||
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large", device=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I would not include optional arguments such as device
to make examples as focused on the task as possible. But let's wait for Merve's opinion :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I remove the device parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadirnar yes
packages/tasks/src/tasks/zero-shot-image-classification/about.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadirnar thanks a lot for standardizing our docs!!! this is very useful 🤗
@@ -15,7 +15,7 @@ With the `transformers` library, you can use the `depth-estimation` pipeline to | |||
```python | |||
from transformers import pipeline | |||
|
|||
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large") | |||
estimator = pipeline(task="depth-estimation", model="Intel/dpt-large", device=0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadirnar yes
Please let's make about.md files more readable. Thanks ❤️