Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added will not echo message to the login token message #1925

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

vtrenton
Copy link
Contributor

@vtrenton vtrenton commented Dec 19, 2023

I embarrassingly hit my head on this when I was setting up hugging face. The token doesn't echo so I thought something was wrong. having it not echo is probably a good security practice so I just added a note to help out folks like me that get confused by this.
The change in this PR is this:
"Token: " -> "Enter your token (input will not be visible): "

Fixes #1924
Thanks!

vtrenton and others added 2 commits December 19, 2023 15:45
Signed-off-by: Trenton VanderWert <trenton.vanderwert@gmail.com>
Co-authored-by: Lucain <lucainp@gmail.com>
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the change! Should be good to merge now :)

@Wauplin Wauplin merged commit dc60d5c into huggingface:main Dec 20, 2023
14 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make note that token from hugging face will not echo
3 participants