Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .github workflow to build cn docs on PRs #1931

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 20, 2023

Follow-up after #1916 cc @2404589803

I realized we forgot to update .github/workflows/build_pr_documentation.yaml to build the "cn" documentation when someone opens a PR. Should be fixed by this PR (I've also ordered alphabetically the languages).

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc60d5c) 48.75% compared to head (6fc0108) 48.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1931      +/-   ##
==========================================
+ Coverage   48.75%   48.78%   +0.02%     
==========================================
  Files          66       66              
  Lines        8132     8132              
==========================================
+ Hits         3965     3967       +2     
+ Misses       4167     4165       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

@adeenayakup adeenayakup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the update!

@Wauplin
Copy link
Contributor Author

Wauplin commented Dec 21, 2023

Thanks for having a look @adeenayakup :)

@Wauplin Wauplin merged commit e063d80 into main Dec 21, 2023
43 of 55 checks passed
@Wauplin Wauplin deleted the build-cn-docs-on-prs branch December 21, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants