Fail early on invalid metadata #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
- Coverage 82.44% 82.43% -0.01%
==========================================
Files 66 66
Lines 8138 8152 +14
==========================================
+ Hits 6709 6720 +11
- Misses 1429 1432 +3 ☔ View full report in Codecov by Sentry. |
LysandreJik
approved these changes
Jan 9, 2024
|
No worries! Thanks for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1927.
If modelcard is invalid, we fail early instead of uploading all the LFS files before getting a bad request error on the
/commitendpoint. This is slightly non-optimized since the model card is transferred twice to the Hub (once for check, once for commit) but by far better UX overall (avoid failing after minutes of waiting).If modelcard is valid but some warnings have been raised, we print those warnings to the user but still continue. Example: empty metadata section.