Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PRODUCTION_TOKEN from all tests #1937

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Dec 21, 2023

In our CI tests we use a production token in two cases:

  1. for Spaces tests => those are flaky and always brake one way or the other (recently because of quotas). This is quite annoying and not very useful as we are more testing the Space infra rather than the huggingface_hub API). This PR updates these tests to use VCR tests instead (requests are replayed without hitting the Hub).
  2. for a gated repo test => this can be done programmatically on staging => updated in this PR

After this PR, we should be able to remove the HUGGINGFACE_PRODUCTION_USER_TOKEN token from Github secrets.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e063d80) 82.39% compared to head (6a99518) 82.42%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
+ Coverage   82.39%   82.42%   +0.03%     
==========================================
  Files          66       66              
  Lines        8132     8132              
==========================================
+ Hits         6700     6703       +3     
+ Misses       1432     1429       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awesome that staging got unlocked for gated repos, will need to update this on transformers' side as well

Cool cassettes!

@Wauplin
Copy link
Contributor Author

Wauplin commented Jan 2, 2024

Thanks for the review!

@Wauplin Wauplin merged commit c3b2c03 into main Jan 2, 2024
16 checks passed
@Wauplin Wauplin deleted the remove-production-token branch January 2, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants