-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix URL in get_safetensors_metadata
docstring
#1951
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 82.42% 82.48% +0.06%
==========================================
Files 66 66
Lines 8154 8155 +1
==========================================
+ Hits 6721 6727 +6
+ Misses 1433 1428 -5 ☔ View full report in Codecov by Sentry. |
Did we encounter a problem with 100kb? I think it's reasonable enough already so wondering if we need the change |
No problems reported no. |
i would also tend to not change anything, personally.. |
Ok, reverted in 456555a. PR becomes "fix typo in docs" :) |
get_safetensors_metadata
docstring
Tweak safetensors parser: fetch only 25kb by default (instead of 100kb currently). Still valid for most use cases (82% in top 1000 models) and save some bandwidth. Most probably won't be noticed. (see #1855 (comment))=> EDIT: not changed in the end.Fix typo in docs: wrong url in
get_safetensors_metadata
docstring.