Fix pagination when listing discussions

[Wauplin]

Pagination in get_repo_discussions is broken which leads to an infinite loop on repos with more than 50 discussions. This PR fixes this. Pagination is page-based (not cursor-based as other listing APIs) and the page parameter is named "p" server-side, not "page_index" (see in moon-landing -private repo-).

I encountered this issue while listing discussions on the Open LLM Leaderboard (cc @clefourrier).

# infinite loop before, now fixed by this PR
for d in get_repo_discussions(repo_id="HuggingFaceH4/open_llm_leaderboard", repo_type="space"):
    print(d.title)

I also made a small change to use requests.get(..., params=...) instead of urlencode.

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc2be44) 82.32% compared to head (d8004df) 82.38%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1962      +/-   ##
==========================================
+ Coverage   82.32%   82.38%   +0.06%     
==========================================
  Files          66       66              
  Lines        8141     8141              
==========================================
+ Hits         6702     6707       +5     
+ Misses       1439     1434       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[LysandreJik]

Great, thanks @Wauplin!

[LysandreJik]

Heavy test 😅

[Wauplin]

Thanks for the review!