Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting CLI default for download --repo-type #1986

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

jamesbraza
Copy link
Contributor

Fixes #1963 by documenting the DownloadCommand's repo-type's default in the help message.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0385794) 79.87% compared to head (c5f8143) 82.42%.

❗ Current head c5f8143 differs from pull request most recent head f308548. Consider uploading reports for the commit f308548 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   79.87%   82.42%   +2.54%     
==========================================
  Files          64       66       +2     
  Lines        7896     8153     +257     
==========================================
+ Hits         6307     6720     +413     
+ Misses       1589     1433     -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's simpler this way indeed :)

src/huggingface_hub/commands/download.py Outdated Show resolved Hide resolved
@Wauplin Wauplin merged commit 177a0ab into huggingface:main Jan 18, 2024
14 checks passed
@jamesbraza jamesbraza deleted the default-repo-type branch January 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs request: CLI default of --repo-type
3 participants