Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused SETUP_CFG path variable #1990

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jamesbraza
Copy link
Contributor

#1971 removed setup.cfg, this PR just removes an unused Path variable for it

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@jamesbraza
Copy link
Contributor Author

The CI failure is a flaky test unrelated to this PR. I don't have permissions to re-run CI failed jobs. (Cc @Wauplin) if you can re-run for me, or give me permissions to re-run it

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesbraza! Failed test is unrelated indeed. I'll have to investigate it. It's not a flaky test, it's also failing in other PRs. I suspect a version update in keras/tensorflow. Anyway, not related so let's merge this!

@Wauplin Wauplin merged commit 9ce6ce9 into huggingface:main Jan 18, 2024
13 of 14 checks passed
@jamesbraza jamesbraza deleted the removing-setup-cfg-var branch January 18, 2024 17:42
@jamesbraza
Copy link
Contributor Author

Yeah looking at the pip freeze of the failed CI job:

...
tb-nightly==2.16.0a20240118
tensorboard-data-server==0.7.2
tensorflow==2.16.0
tensorflow-io-gcs-filesystem==0.35.0
...
tf-estimator-nightly==2.14.0.dev2023080308
tf_keras-nightly==2.16.0.dev2024011811
...

For some reason it's installing the nightly version of 2.16, which doesn't make sense to me because that's not what setup.py calls out for the tensorflow extra. The only place tf-nightly is mentioned is in utils/_runtime.py.

Anyways, feel free to tag me on a PR for the fix, if you can figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants