-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HfFileSystem] Copy non lfs files #1996
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @lhoestq :) I would prefer not to rely on the fsspec
overhead when downloading the regular files since a simple http request is also fine. All comments are about making this change.
As an additional change, could you update the docstring of CommitOperationCopy
now that non-LFS copies are enabled on the repo. Otherwise, looks good to me :) Glad that the testing part was that easy :D Thanks in advance!
Co-authored-by: Lucain <lucainp@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1996 +/- ##
==========================================
- Coverage 82.39% 82.32% -0.07%
==========================================
Files 66 66
Lines 8240 8247 +7
==========================================
Hits 6789 6789
- Misses 1451 1458 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @lhoestq! Ready to be merged :)
Added CommitOperationCopy support for non-lfs files.
This test already exists to check that copying works with hffs:
huggingface_hub/tests/test_hf_file_system.py
Lines 188 to 194 in 8a9854f
I simply removed the condition in hffs to use CommitOperationCopy even for non-lfs files.
Close huggingface/dataset-viewer#2317