Fix intolerance for new field in TGI stream response: 'index' #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpcox
changed the title
danielpcox
changed the title
danielpcox
changed the title
Wauplin
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Hi @danielpcox! Thanks a ton for reporting the issue, investigating it and opening a PR to fix it! The PR looks good to me 👍
I've triggered the CI. Let's wait for it to complete and then we should be good to merge 🤗
EDIT: I've just pushed a commit to your branch for styling issues. Hope that's fine with you.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
I've slightly iterated on the test and it's now ready to be merged! CI is currently failing but it's unrelated. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2005
This PR adds tolerance for an
indexfield in the TextGenerationStreamResponse.The latest version of HuggingFace Text Generation Inference added an
indexfield to the streaming response to be compatible with OpenAI clients, but the HuggingFace InferenceClient wasn't updated to accept it.huggingface/text-generation-inference@0eabc83#diff-c3259a23eb2e9e4e39f9a5226354b99508e42b05a158036dc482397410becd52R501