Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy parameters in update_repo_visibility #2014

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Feb 5, 2024

update_repo_visibility currently accepts name and organization as input. This PR deprecate them in favor of repo_id cc @severo who pinged me about it.

(for the record, I haven't found any use of these inputs in transformers/diffusers/datasets/etc. or on github)

@Wauplin Wauplin requested a review from severo February 5, 2024 08:45
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor Author

Wauplin commented Feb 5, 2024

Failing tests are unrelated. Merging this one.

@Wauplin Wauplin merged commit 8edc3f4 into main Feb 5, 2024
13 of 16 checks passed
@Wauplin Wauplin deleted the deprecate-legacy-params branch February 5, 2024 09:14
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants