-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added audio to audio in inference client #2020
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
==========================================
- Coverage 82.40% 82.34% -0.06%
==========================================
Files 66 66
Lines 8222 8240 +18
==========================================
+ Hits 6775 6785 +10
- Misses 1447 1455 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clean PR @Ahmedniz1! I've added some comments but it's already a very good start! 🔥 I think you've already noticed but running make style
will automatically reflect the sync
client changes to the async
one :)
And thanks for the clean docstring! It's very good to have it 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ahmedniz1, thanks for making the changes! I wanted to try this new API locally but the audio-to-audio
inference server seems broken since yesterday. I've reported it internally. Once it's fixed and I've been able to test it, we should be good to merge! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ahmedniz1, I'm getting back to you regarding this PR. The bug I mentioned above has been fixed and I have been able to test your implementation correctly. I just pushed 2 commits to add a proper test and to list audio_to_audio
as a supported task. PR looks good to me. I'll merge it as soon as the CI passes! Thanks for the great job 🤗
This PR aims to resolve issue #2016 . I've added the required code, have tested it on my end in a separate script.