Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting widget_data from model_info #2041

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix getting widget_data from model_info #2041

merged 1 commit into from
Feb 22, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Feb 22, 2024

When getting information about a model, we need to parse widgetData, not widget_data. It probably never worked correctly^^. Fixed it and added a test.

See for example https://huggingface.co/api/models/HuggingFaceH4/zephyr-7b-beta.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e05fb73) 82.22% compared to head (9c0b76e) 82.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2041   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files          66       66           
  Lines        8309     8309           
=======================================
  Hits         6832     6832           
  Misses       1477     1477           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wauplin Wauplin merged commit 4de2e4f into main Feb 22, 2024
16 checks passed
@Wauplin Wauplin deleted the fix-widget-data branch February 22, 2024 14:12
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with this fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants