Fix Space variable when updatedAt is missing #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
+ Coverage 80.60% 80.64% +0.03%
==========================================
Files 71 71
Lines 8518 8519 +1
==========================================
+ Hits 6866 6870 +4
+ Misses 1652 1649 -3 ☔ View full report in Codecov by Sentry. |
Wauplin
added a commit
that referenced
this pull request
Feb 27, 2024
* Fix Space variable when updatedAt is missing * var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In moon-landing (private repo), the
updatedAtfield is optional for Space variables. Never noticed before but it brakes the date parsing in that case. This PR fixes this by making the field optional in Python as well.Encountered this bug while investigating an issue on https://huggingface.co/spaces/Wauplin/gradio-space-ci