[HfFileSystem] Fix glob with pattern without wildcards #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
commented
Feb 28, 2024
| @@ -557,7 +557,7 @@ def info(self, path: str, refresh: bool = False, revision: Optional[str] = None, | |||
| def exists(self, path, **kwargs): | |||
| """Is there a file at the given path""" | |||
| try: | |||
| self.info(path, expand_info=False, **kwargs) | |||
| self.info(path, **{**kwargs, "expand_info": False}) | |||
There was a problem hiding this comment.
this was causing a TypeError: huggingface_hub.hf_file_system.HfFileSystem.info() got multiple values for keyword argument 'expand_info'
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 80.36% 80.70% +0.34%
==========================================
Files 71 71
Lines 8519 8519
==========================================
+ Hits 6846 6875 +29
+ Misses 1673 1644 -29 ☔ View full report in Codecov by Sentry. |
|
@lhoestq I just shipped hot-fix release 0.21.2: |
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported in huggingface/datasets#6687
This is currently impacting
datasetsand DVC folks (preventing to use the latest fsspec versions) so it would be great to have a patch release once it's merged