Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token type definition and arg description in hf_file_system.py #2278

Merged
merged 2 commits into from May 22, 2024

Conversation

lappemic
Copy link
Contributor

Refactor token argument in hf_file_system.py for consistency across the hub.

  • Standardize the type definition of the token parameter to Union[bool, str, None] = None
  • Unify docstring descriptions for the token parameter to enhance clarity and usage guidance

See #2251 and #2252 for related discussions.

Thought i just go on and open a PR for this.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lappemic! Looks good to merge :)

src/huggingface_hub/hf_file_system.py Outdated Show resolved Hide resolved
@Wauplin Wauplin merged commit a6fbf16 into huggingface:main May 22, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants