fix Parameter dtype in audio models #30310
Merged
+33
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_wav2vec2_conformer_float16
was failing becausemasked_spec_embed
is initialized as afp32
tensor.transformers/src/transformers/models/wav2vec2_conformer/modeling_wav2vec2_conformer.py
Line 1238 in 28a2283
I thus changed the tensor from
FloatTensor
toTensor
. Ideally, I would have moved the.uniform_
, to the_init_weights
, but turns thatmodel.apply
doesn't iterate onParameter
.Slow tests on every modeling tests of the files I've changed all passed, but I might have missed some other tests to run, any ideas @ydshieh ?
cc @ydshieh because of the failing test and @ArthurZucker because we've talked about it