Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: fix pad_token_id again #30338

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Apr 19, 2024

What does this PR do?

Related to PR #30285. The earlier PR caused audio-to-text pipelines to fail in daily doctest CI, because they do not accept pad-token-id in kwargs. This should be a better solution, to set pad token directly in model's config

@zucchini-nlp zucchini-nlp self-assigned this Apr 19, 2024
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Double-checking: Have you run the pipeline tests locally?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp
Copy link
Member Author

Yes, all tests in pipeline + doctest are running green on my end mostly. Some tests that are failing are not related to the fix, maybe hardware issues

@gante
Copy link
Member

gante commented Apr 19, 2024

CI passing now :) it was an temporary issue on the ubuntu package servers, it seems

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@zucchini-nlp zucchini-nlp merged commit 91472cf into huggingface:main Apr 19, 2024
21 checks passed
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants