Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: re-add bnb on docker image #30427

Merged
merged 1 commit into from
Apr 23, 2024
Merged

FIX: re-add bnb on docker image #30427

merged 1 commit into from
Apr 23, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Apr 23, 2024

What does this PR do?

Addresses: #30408 (comment) - some tests require bnb to be run for more memory efficient testing

cc @ydshieh @amyeroberts @SunMarc

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my mistake!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@younesbelkada younesbelkada merged commit d179b9d into main Apr 23, 2024
8 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch April 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants