Add paths filter to avoid the chance of being triggered
#30453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
force-pushed
the
improve_new_model_pr_ci
branch
from
d8bdddd to
a3e01fc
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
commented
Apr 24, 2024
Comment on lines
-111
to
-125
|
|
||
| slow_test_result: | ||
| runs-on: ubuntu-22.04 | ||
| name: Check slow test status | ||
| needs: [check_for_new_model, run_new_model_tests] | ||
| if: always() | ||
| steps: | ||
| - name: Check test status | ||
| shell: bash | ||
| # NOT a new model PR --> pass | ||
| # new model PR --> pass only if `run_new_model_tests` gives `success` (so if the label is not added, we fail | ||
| # this job even if `run_new_model_tests` has `skipped` status). | ||
| run: | | ||
| echo "${{ needs.run_new_model_tests.result }}" | ||
| if [ "${{ needs.check_for_new_model.outputs.new_model }}" = "" ]; then echo "not new model"; elif [ "${{ needs.run_new_model_tests.result }}" != "success" ]; then echo "failure"; exit -1; else echo "pass"; fi; |
There was a problem hiding this comment.
Removed this one (forgot to do it in the first commit).
This job was here only to make our status check on the repository setting work - but we no longer use that tool, so this job is no longer useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We decide to remove the status check from the repository setting, i.e. no more
Check slow test statusas in the following screenshot.Therefore, we don't need to trigger the workflow file all the time. This PR adds a
pathsfilter. The workflow will be triggered only if there is a change matchingsrc/transformers/models/*/modeling_*.py.Approve and runmost of the time.Approve and runwould be shown and waits for click.single-model-run-slowis added), and the reviewers can check it is ✅ or ❌ (which is easy to identify).