Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #29817 Video Classification Task Guide Using Undeclared Variables #30457

Merged

Conversation

manju-rangam
Copy link
Contributor

This PR fixes the following issue #29817

Fixes # 29817

Updates the Video_Clasification.md file to define the value of the variable all_video_file_paths

Before submitting

  • [ x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ x] Did you read the contributor guideline,
    Pull Request section?
  • [ x] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • [ x] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Sorry, something went wrong.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Just two small comments

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

manju-rangam and others added 3 commits April 25, 2024 07:30
Video Classification Task Guide Using Undeclared Variables
updated with review comments

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Add line space following PR comments
@manju-rangam manju-rangam force-pushed the feature/update_video_classfn_doc branch from 854dc4b to 5dc662f Compare April 25, 2024 06:36
@manju-rangam
Copy link
Contributor Author

@amyeroberts , fixed your comments, thank you.

@amyeroberts
Copy link
Collaborator

Thanks again for fixing! ❤️

@amyeroberts amyeroberts merged commit 9283313 into huggingface:main Apr 25, 2024
8 checks passed
@manju-rangam manju-rangam deleted the feature/update_video_classfn_doc branch April 29, 2024 14:24
@manju-rangam manju-rangam restored the feature/update_video_classfn_doc branch April 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants