Update dtype_byte_size
to handle torch.float8_e4m3fn/float8_e5m2 types
#30488
+32
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently using the new
torch.float8_e4m3fn
dtype will cause an error becausedtype_byte_size()
doesn't know where to find the number of bits in the dtype string.Code to reproduce:
Error:
We can fix this by changing the regex from

[^\d](\d+)$
to[^\d](\d+)_?
so we match on every set of numbers following an alphabetical character. This can match multiple groups, but we can always look at the first group to get the first number which is significant. See the picture below for a demonstration of the matches on all numbered pytorch dtypes:Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Tagging @sgugger since they touched this function last.