Docs: add missing StoppingCriteria autodocs
#30617
Merged
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
May 2, 2024
| @@ -98,7 +98,7 @@ class MaxNewTokensCriteria(StoppingCriteria): | |||
|
|
|||
| def __init__(self, start_length: int, max_new_tokens: int): | |||
| warnings.warn( | |||
| "The class `MaxNewTokensCriteria` is deprecated. " | |||
| "The class `MaxNewTokensCriteria` is deprecated and will be removed in v4.42. " | |||
There was a problem hiding this comment.
nit - this will be in the 4.41 release and we normally deprecate in 2 release cycles
Suggested change
| "The class `MaxNewTokensCriteria` is deprecated and will be removed in v4.42. " | |
| "The class `MaxNewTokensCriteria` is deprecated and will be removed in v4.43. " |
There was a problem hiding this comment.
Added :)
My intuition for the new version + 1 was due to how old this one was: it was deprecated 3 years ago
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
They were not in the main
__init__, somake fixupdidn't complain :)cc @zucchini-nlp @Rocketknight1