Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantization / HQQ: Fix HQQ tests on our runner #30668

Merged
merged 2 commits into from
May 6, 2024

Conversation

younesbelkada
Copy link
Contributor

What does this PR do?

Link to failing job: https://github.com/huggingface/transformers/actions/runs/8955054995

Fixes the current failing CI for HQQ, using bf16 fails on our T4 runners since SDPA + bf16 is not supported and we simply put cache_dir as an optional argument

cc @SunMarc @amyeroberts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada requested review from LysandreJik and removed request for amyeroberts May 6, 2024 09:01
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but let's not merge, I need to investigate what is going on with the tests here

@ArthurZucker
Copy link
Collaborator

#30669 will adress the failing tests

@younesbelkada younesbelkada merged commit 9c772ac into main May 6, 2024
18 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-fix-hqq branch May 6, 2024 09:33
Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing de CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants