Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Token classification for Udop #30672

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

nileshkokane01
Copy link
Contributor

@nileshkokane01 nileshkokane01 commented May 6, 2024

What does this PR do?

Fixes #29800

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@NielsRogge

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@nileshkokane01
Copy link
Contributor Author

@NielsRogge ,
Adding to all_model_classes causes 10 errors. Any hint ?
As of now I have commented UdopForTokenClassification .

@amyeroberts
Copy link
Collaborator

Hi @nileshkokane01, thanks for opening a PR! Are there checkpoints available for this task-specific model? We tend to reserve these additions to situations when this is the case

@nileshkokane01
Copy link
Contributor Author

Guess not. Not official ones at least to my sight.

The original Issue was inspired from the example code of @NielsRogge .
(https://github.com/NielsRogge/Transformers-Tutorials/blob/master/UDOP%2FFine_tune_UDOPEncoderModel_on_FUNSD_%28HuggingFace_Trainer%29.ipynb)

He may have a better idea as to why it was a "Good first issue”, or could perhaps point to an available checkpoint.

@amyeroberts
Copy link
Collaborator

@nileshkokane01 OK, thanks for clarifying. I've removed the label. In this case, we won't merge in. We can leave this PR as a reference in case anyone in the community would like to see how to add it in their own code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding UDopForTokenClassification to be able to use UDOP for token classification tasks on Documents
2 participants