-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: gdb logging enable/disable command #1095
Conversation
'set logging on/off' is deprecated and replaced with 'set logging enabled on/off'
Do you happen to know in which version this deprecation occured? Update: it seems to have appeared somewhere between v9 (doesn't work) and v12 (works). |
Thanks for reminding me. So do I need to add an if judgment to choose to use 'set logging on/off' or 'set logging enabled on/off' based on GDB_VERSION? |
From the docs it seems that |
Hi, I just added those judgments mentioned above. |
@mtwoz Code formatting fails. Please fix and re-submit. Once it passes it can be merged. |
OK. Thanks. I just fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
'set logging on/off' is deprecated and replaced with 'set logging enabled on/off'.
Description