Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/removed PSR-2-R rule #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfrommen
Copy link
Contributor

@tfrommen tfrommen commented Feb 10, 2021

The PSR2R.Namespaces.UseInAlphabeticalOrder rule has been removed from the PSR-2-R standard, so we should remove it, too. As soon as we'd update the standard, it would break anyway. See #245.

@tfrommen tfrommen self-assigned this Feb 10, 2021
@rmccue
Copy link
Member

rmccue commented Feb 10, 2021

We'll need to copy the rule itself over I think?

@tfrommen
Copy link
Contributor Author

@rmccue well, it's not working as intended, that's why it has been removed. If we want to keep the behavior, I suggest to use the AlphabeticallySortedUses sniff in the Slevomat Coding Standards. This is already a dependency of PSR-2-R, as of version 1.0.0.

@rmccue
Copy link
Member

rmccue commented Feb 10, 2021

Works for me; can you update this PR to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants