This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
[WIP] Support for phpspec (reset) #145
Open
padraic
wants to merge
5
commits into
master
Choose a base branch
from
phpspec-reset
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking forward to this 👍 |
Are there some fundamental problems here due to how phpspec works? Or simply a lack of time to finish it? I would love to try this out with phpspec. |
Closed
need some help here? |
It would be awesome is someone could finish this ❤️ |
@theofidry I am starting to look at humbug to make it compatible with phpunit6 now that I got two of its dependencies up to speed. After that, I might be interested in picking this up. |
There's a phpspec-extensions repo attached to the organisation also. Might need some TLC beforehand. |
@omissis No, but I always worry that something written in 2015 might not work so well in 2017 ;). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of the previous WIP updated for the new refactored internals.