This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Add config to use custom phpunit.humbug.xml (e.g for symfony project) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
suggested changes
Apr 19, 2017
There was a problem hiding this comment.
While I think this is a nice feature, there is besides the comment two things to consider:
- Ensure that this config file is overridable with an argument when invoking humbug
- I'm not sure about the entry key if we add support for say phpSpec for example (as you could very well use both PHPUnit and phpSpec)
tests/Adapter/PhpunitTest.php
Outdated
| { | ||
| $container = m::mock('\Humbug\Container'); | ||
| $container->shouldReceive([ | ||
| 'getSourceList' => $this->root, |
There was a problem hiding this comment.
can you remove the unnecessary whitespace between the arrows please?
tests/Adapter/PhpunitTest.php
Outdated
| ]); | ||
| ; | ||
| $adapter = new Phpunit; | ||
| $process = $adapter->getProcess( |
There was a problem hiding this comment.
I think this can be a one liner
|
Also needs to be documented. It's relatively simple, so I might look at it later over the weekend. |
padraic
suggested changes
Apr 22, 2017
tabbabi
force-pushed
the
add-humbug-config
branch
3 times, most recently
from
126c15d
to
67be9e2
Compare
tabbabi
force-pushed
the
add-humbug-config
branch
from
67be9e2
to
0a6af39
Compare
|
@tabbabi could you add the missing doc? After that I think it will be ready to be merged :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ "source": { "directories": [ "src" ], "excludes": [ "vendor" ] }, "chdir": "app", "configure": "app/humbug/phpunit.humbug.xml", "timeout": 30, "logs": { "text": "humbuglog.txt", "json": "humbuglog.json" } }