This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Generalise, document and include a test for custom phpunit path #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
padraic
commented
May 13, 2017
•
padraic
commented
- Modifies Support for optionally configuring phpunit executable #155 to be slightly more general in nature (filepath vs phar).
- Notes configuration in README.
- Added to configure command questions.
This was referenced May 13, 2017
padraic
commented
May 13, 2017
|
|
||
| public function testFinderCanLocateACustomPhpunitNotInVendorOrPath() | ||
| { | ||
| $this->markTestIncomplete('Design test to inject custom config for this.'); |
There was a problem hiding this comment.
Leaving this aside for the time being. There's no clean way to inject the config change needed at the moment.
padraic
commented
May 13, 2017
| @@ -107,6 +103,7 @@ public function testShouldCreateConfigurationWithDifferentLocationOfFrameworkCon | |||
| "\n" . | |||
| "\n" . | |||
| "\n" . | |||
| "\n" . | |||
There was a problem hiding this comment.
Extra line of input was needed for all tests with the new configure question included.
pamil
approved these changes
May 15, 2017
theofidry
reviewed
May 15, 2017
| ] | ||
| } | ||
| "phpunit": { | ||
| "filepath": "/absolute/path/to/phpunit-5.7.phar" |
There was a problem hiding this comment.
can we allow a relative file path (relative to the config file)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.