Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Add the missing abstract method MutatorAbstract::getMutation() #255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add the missing abstract method MutatorAbstract::getMutation() #255

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor

@villfa villfa commented May 15, 2017

All classes inheriting from MutatorAbstract already have the getMutation() method but it is not properly declared.

@villfa
Copy link
Contributor Author

villfa commented May 15, 2017 •
edited

I don't know why the build fails only with PHP 5.6 and I don't have a PHP-5.6 environment to reproduce the problem.

padraic
padraic reviewed May 15, 2017
View reviewed changes
Copy link
Collaborator

@padraic padraic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be held for Humbug 2.0 though as it's a static functions - see the Travis CI failure for PHP 5.6.

@padraic padraic added this to the 2.0.0 milestone May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@padraic padraic padraic approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@villfa @padraic