This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
Manifest file strategy (updated) #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updater into pjcdawkins-manifest-strategy
aik099
suggested changes
May 14, 2017
src/Strategy/ManifestStrategy.php
Outdated
| throw new RuntimeException(sprintf('Failed to write file: %s', $tmpFilename)); | ||
| } | ||
|
|
||
| $tmpSha = sha1_file($tmpFilename); |
There was a problem hiding this comment.
Are you sure, that sha1 should be used for version verification? Considering recent findings on http://shattered.io/ it is possible to create another phar with same sha1 hash.
There was a problem hiding this comment.
It's on the todo list. I'm thinking about scrapping sha1 altogether since this is a new feature.
There was a problem hiding this comment.
Slight backtrack. I'm allowing SHA-1, but not by default, to allow for any transitioning, e.g. platform.sh which this is based of off.
|
@humbug/core Ready for review. |
padraic
changed the title
This was referenced May 14, 2017
theofidry
approved these changes
May 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revision of the original #15, to work around not having write access on older PRs.