Remove requirement for makeContext closure #352
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #352 +/- ##
==========================================
- Coverage 83.73% 83.68% -0.05%
==========================================
Files 93 93
Lines 5059 5052 -7
==========================================
- Hits 4236 4228 -8
- Misses 823 824 +1 ☔ View full report in Codecov by Sentry. |
|
The problem with this is that |
|
Yeah but how do you create an HBXCTRouter if the only |
|
@Joannis Given we now have HummingbirdLambdaTesting can I resurrect this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we require
Responder.Context: HBRequestContextto conform toHBRequestContextwe can remove the need for amakeContextclosure