Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make LocalFileSystem.init public #451

Merged
merged 1 commit into from
May 15, 2024

Conversation

alephao
Copy link
Contributor

@alephao alephao commented May 14, 2024

As mentioned in the discord, I would like to use LocalFileSystem for a implementing something similar to FileMiddleware, but the initializer is currently internal.

LocalFileSystem itself and all of its methods are public.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.54%. Comparing base (e78cde7) to head (9843c9c).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
- Coverage   84.86%   83.54%   -1.33%     
==========================================
  Files          98      103       +5     
  Lines        5320     4303    -1017     
==========================================
- Hits         4515     3595     -920     
+ Misses        805      708      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler merged commit b303533 into hummingbird-project:main May 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants