(fix) add error logging and improve modularity #6686
+59
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SummerAnn
commented
Nov 28, 2023
•
SummerAnn
commented
- Added error logging to Security.decrypt_all in security.py to assist with debugging issue Client - UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in position 2: invalid start byte #6671 raised during call to ETHKeyFileSecretManger.decrypt_secret_value
- Added error logging to ETHKeyFileSecretManger.decrypt_secret_value in config_crypt.py to assist with debugging issue Client - UnicodeDecodeError: 'utf-8' codec can't decode byte 0xac in position 2: invalid start byte #6671 raised during call to ETHKeyFileSecretManger.decrypt_secret_value
- Added functions to PreviousCommand in previous_strategy_command.py to improve readability and maintainability.
- Added functions to ConfigCommand in config_command.py to improve readability and maintainability.
SummerAnn
changed the title
|
hi @SummerAnn Please review contribution guidelines, PR needs to be submitted from development and pointed https://hummingbot.org/developers/contributions/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.